Skip to content

fix: make all tests pass and typecheck clean - #294

Open
stooit wants to merge 1 commit into
mainfrom
quantcode/e2e-tier2-897-1794413888
Open

stooit wants to merge 1 commit into
mainfrom
quantcode/e2e-tier2-897-1794413888

Conversation

@stooit

@stooit stooit commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Fixes: auth POST casing ("post"→"POST"), missing badRequest import in users route, User.userName→username, implemented paginate, added types: [bun-types] to tsconfig (existing devDependency).

Verification: bun test 22/22 pass; tsc --noEmit clean (run via node_modules/.bin/tsc, not on PATH).

Assumptions / follow-ups:

  • All POST routes unauthenticated is intentional per policy comment and tests — confirm for production.
  • paginate lacks guards for page<1 / size<=0 (not required by tests; unused by routes).
  • Pre-existing hardcoded test-token fallback for API_TOKEN should be removed in a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant